Feature/credential provider service #3143
Open
+672
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reateCredentialRequest
PhilippC
reviewed
Jan 6, 2026
Owner
PhilippC
left a comment
PhilippC
left a comment
There was a problem hiding this comment.
Thanks for creating the PR! Unfortunately I wasn't able to test it successfully. Do I need to enable anything first because KP2A now pops up as credential prodvider service in the CredentialManagerSample?
src/keepass2android-app/services/Kp2aCredentialProvider/Kp2aCredentialLauncherActivity.cs
Outdated
Show resolved
Hide resolved
Author
I think you will need to enable the service in "Settings" > "Passwords, Passkeys and Accounts" |
mohammaduvez
force-pushed
the
feature/credential-provider-service
branch
from
98cc8f6 to
d0996d4
Compare
prokopCerny
reviewed
Jan 12, 2026
src/Kp2aBusinessLogic/IKp2aApp.cs
Outdated
| void RegisterPendingActionForContextInstance(int contextInstanceId, ActionOnOperationFinished actionToPerformWhenContextIsResumed); | ||
|
|
||
| /// <summary> | ||
| /// Use an App level (singletone) AotmicInteger |
There was a problem hiding this comment.
Suggested change
| /// Use an App level (singletone) AotmicInteger | |
| /// Use an App level (singleton) AtomicInteger |
fix typos
…etCredentialRequest
mohammaduvez
force-pushed
the
feature/credential-provider-service
branch
from
d0996d4 to
7fb0c19
Compare
PhilippC
reviewed
Jan 13, 2026
src/keepass2android-app/services/Kp2aCredentialProvider/Kp2aCredentialLauncherActivity.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of credential provider service to store and return password credential.